feat: implement idempotency key for critical API endpoints

2026-06-04 00:48:50 +07:00
parent 2ab20a1150
commit b228538725
21 changed files with 431 additions and 37 deletions
@@ -4,6 +4,7 @@ import 'package:bloc/bloc.dart';
 import 'package:dartz/dartz.dart' hide Order;
 import 'package:freezed_annotation/freezed_annotation.dart';
 import 'package:injectable/injectable.dart' hide Order;
+import 'package:uuid/uuid.dart';

 import '../../../common/types/split_type.dart';
 import '../../../domain/order/order.dart';
@@ -38,7 +39,15 @@ class PaymentFormBloc extends Bloc<PaymentFormEvent, PaymentFormState> {
      submitted: (e) async {
        Either<OrderFailure, Payment> failureOrPayment;

-        emit(state.copyWith(isSubmitting: true, failureOrPayment: none()));
+        // Generate new idempotency key saat user intent (tap Bayar)
+        // Kalau sedang retry (isSubmitting sebelumnya gagal), pakai key yang sama
+        final idempotencyKey = state.idempotencyKey ?? const Uuid().v4();
+
+        emit(state.copyWith(
+          isSubmitting: true,
+          failureOrPayment: none(),
+          idempotencyKey: idempotencyKey,
+        ));

        final request = PaymentRequest(
          orderId: state.order.id,
@@ -58,20 +67,32 @@ class PaymentFormBloc extends Bloc<PaymentFormEvent, PaymentFormState> {
              .toList(),
        );

-        failureOrPayment = await _repository.createPayment(request: request);
+        failureOrPayment = await _repository.createPayment(
+          request: request,
+          idempotencyKey: idempotencyKey,
+        );

        emit(
          state.copyWith(
            isSubmitting: false,
            failureOrPayment: optionOf(failureOrPayment),
+            // Clear key on success, keep on failure for retry
+            idempotencyKey: failureOrPayment.isRight() ? null : idempotencyKey,
          ),
        );
      },
      submittedSplitBill: (e) async {
        Either<OrderFailure, Payment> failureOrPayment;

+        // Generate new idempotency key untuk split bill
+        final idempotencyKey = state.splitBillIdempotencyKey ?? const Uuid().v4();
+
        emit(
-          state.copyWith(isSubmitting: true, failureOrPaymentSplitBill: none()),
+          state.copyWith(
+            isSubmitting: true,
+            failureOrPaymentSplitBill: none(),
+            splitBillIdempotencyKey: idempotencyKey,
+          ),
        );

        final request = PaymentSplitBillRequest(
@@ -93,12 +114,18 @@ class PaymentFormBloc extends Bloc<PaymentFormEvent, PaymentFormState> {

        log(request.toString());

-        failureOrPayment = await _repository.createSplitBill(request);
+        failureOrPayment = await _repository.createSplitBill(
+          request,
+          idempotencyKey: idempotencyKey,
+        );

        emit(
          state.copyWith(
            isSubmitting: false,
            failureOrPaymentSplitBill: optionOf(failureOrPayment),
+            // Clear key on success, keep on failure for retry
+            splitBillIdempotencyKey:
+                failureOrPayment.isRight() ? null : idempotencyKey,
          ),
        );
      },
@@ -813,6 +813,14 @@ mixin _$PaymentFormState {
  PaymentMethod? get paymentMethod => throw _privateConstructorUsedError;
  bool get isSubmitting => throw _privateConstructorUsedError;

+  /// Idempotency key untuk payment submission.
+  /// Di-generate saat user tap "Bayar", dipakai ulang saat retry,
+  /// di-clear setelah sukses.
+  String? get idempotencyKey => throw _privateConstructorUsedError;
+
+  /// Idempotency key untuk split bill submission.
+  String? get splitBillIdempotencyKey => throw _privateConstructorUsedError;
+
  /// Create a copy of PaymentFormState
  /// with the given fields replaced by the non-null parameter values.
  @JsonKey(includeFromJson: false, includeToJson: false)
@@ -834,6 +842,8 @@ abstract class $PaymentFormStateCopyWith<$Res> {
    Option<Either<OrderFailure, Payment>> failureOrPaymentSplitBill,
    PaymentMethod? paymentMethod,
    bool isSubmitting,
+    String? idempotencyKey,
+    String? splitBillIdempotencyKey,
  });

  $OrderCopyWith<$Res> get order;
@@ -861,6 +871,8 @@ class _$PaymentFormStateCopyWithImpl<$Res, $Val extends PaymentFormState>
    Object? failureOrPaymentSplitBill = null,
    Object? paymentMethod = freezed,
    Object? isSubmitting = null,
+    Object? idempotencyKey = freezed,
+    Object? splitBillIdempotencyKey = freezed,
  }) {
    return _then(
      _value.copyWith(
@@ -888,6 +900,14 @@ class _$PaymentFormStateCopyWithImpl<$Res, $Val extends PaymentFormState>
                ? _value.isSubmitting
                : isSubmitting // ignore: cast_nullable_to_non_nullable
                      as bool,
+            idempotencyKey: freezed == idempotencyKey
+                ? _value.idempotencyKey
+                : idempotencyKey // ignore: cast_nullable_to_non_nullable
+                      as String?,
+            splitBillIdempotencyKey: freezed == splitBillIdempotencyKey
+                ? _value.splitBillIdempotencyKey
+                : splitBillIdempotencyKey // ignore: cast_nullable_to_non_nullable
+                      as String?,
          )
          as $Val,
    );
@@ -934,6 +954,8 @@ abstract class _$$PaymentFormStateImplCopyWith<$Res>
    Option<Either<OrderFailure, Payment>> failureOrPaymentSplitBill,
    PaymentMethod? paymentMethod,
    bool isSubmitting,
+    String? idempotencyKey,
+    String? splitBillIdempotencyKey,
  });

  @override
@@ -962,6 +984,8 @@ class __$$PaymentFormStateImplCopyWithImpl<$Res>
    Object? failureOrPaymentSplitBill = null,
    Object? paymentMethod = freezed,
    Object? isSubmitting = null,
+    Object? idempotencyKey = freezed,
+    Object? splitBillIdempotencyKey = freezed,
  }) {
    return _then(
      _$PaymentFormStateImpl(
@@ -989,6 +1013,14 @@ class __$$PaymentFormStateImplCopyWithImpl<$Res>
            ? _value.isSubmitting
            : isSubmitting // ignore: cast_nullable_to_non_nullable
                  as bool,
+        idempotencyKey: freezed == idempotencyKey
+            ? _value.idempotencyKey
+            : idempotencyKey // ignore: cast_nullable_to_non_nullable
+                  as String?,
+        splitBillIdempotencyKey: freezed == splitBillIdempotencyKey
+            ? _value.splitBillIdempotencyKey
+            : splitBillIdempotencyKey // ignore: cast_nullable_to_non_nullable
+                  as String?,
      ),
    );
  }
@@ -1004,6 +1036,8 @@ class _$PaymentFormStateImpl implements _PaymentFormState {
    required this.failureOrPaymentSplitBill,
    this.paymentMethod,
    this.isSubmitting = false,
+    this.idempotencyKey,
+    this.splitBillIdempotencyKey,
  }) : _pendingItems = pendingItems;

  @override
@@ -1026,9 +1060,19 @@ class _$PaymentFormStateImpl implements _PaymentFormState {
  @JsonKey()
  final bool isSubmitting;

+  /// Idempotency key untuk payment submission.
+  /// Di-generate saat user tap "Bayar", dipakai ulang saat retry,
+  /// di-clear setelah sukses.
+  @override
+  final String? idempotencyKey;
+
+  /// Idempotency key untuk split bill submission.
+  @override
+  final String? splitBillIdempotencyKey;
+
  @override
  String toString() {
-    return 'PaymentFormState(order: $order, pendingItems: $pendingItems, failureOrPayment: $failureOrPayment, failureOrPaymentSplitBill: $failureOrPaymentSplitBill, paymentMethod: $paymentMethod, isSubmitting: $isSubmitting)';
+    return 'PaymentFormState(order: $order, pendingItems: $pendingItems, failureOrPayment: $failureOrPayment, failureOrPaymentSplitBill: $failureOrPaymentSplitBill, paymentMethod: $paymentMethod, isSubmitting: $isSubmitting, idempotencyKey: $idempotencyKey, splitBillIdempotencyKey: $splitBillIdempotencyKey)';
  }

  @override
@@ -1051,7 +1095,14 @@ class _$PaymentFormStateImpl implements _PaymentFormState {
            (identical(other.paymentMethod, paymentMethod) ||
                other.paymentMethod == paymentMethod) &&
            (identical(other.isSubmitting, isSubmitting) ||
-                other.isSubmitting == isSubmitting));
+                other.isSubmitting == isSubmitting) &&
+            (identical(other.idempotencyKey, idempotencyKey) ||
+                other.idempotencyKey == idempotencyKey) &&
+            (identical(
+                  other.splitBillIdempotencyKey,
+                  splitBillIdempotencyKey,
+                ) ||
+                other.splitBillIdempotencyKey == splitBillIdempotencyKey));
  }

  @override
@@ -1063,6 +1114,8 @@ class _$PaymentFormStateImpl implements _PaymentFormState {
    failureOrPaymentSplitBill,
    paymentMethod,
    isSubmitting,
+    idempotencyKey,
+    splitBillIdempotencyKey,
  );

  /// Create a copy of PaymentFormState
@@ -1086,6 +1139,8 @@ abstract class _PaymentFormState implements PaymentFormState {
    failureOrPaymentSplitBill,
    final PaymentMethod? paymentMethod,
    final bool isSubmitting,
+    final String? idempotencyKey,
+    final String? splitBillIdempotencyKey,
  }) = _$PaymentFormStateImpl;

  @override
@@ -1101,6 +1156,16 @@ abstract class _PaymentFormState implements PaymentFormState {
  @override
  bool get isSubmitting;

+  /// Idempotency key untuk payment submission.
+  /// Di-generate saat user tap "Bayar", dipakai ulang saat retry,
+  /// di-clear setelah sukses.
+  @override
+  String? get idempotencyKey;
+
+  /// Idempotency key untuk split bill submission.
+  @override
+  String? get splitBillIdempotencyKey;
+
  /// Create a copy of PaymentFormState
  /// with the given fields replaced by the non-null parameter values.
  @override
@@ -9,6 +9,12 @@ class PaymentFormState with _$PaymentFormState {
    required Option<Either<OrderFailure, Payment>> failureOrPaymentSplitBill,
    PaymentMethod? paymentMethod,
    @Default(false) bool isSubmitting,
+    /// Idempotency key untuk payment submission.
+    /// Di-generate saat user tap "Bayar", dipakai ulang saat retry,
+    /// di-clear setelah sukses.
+    String? idempotencyKey,
+    /// Idempotency key untuk split bill submission.
+    String? splitBillIdempotencyKey,
  }) = _PaymentFormState;

  factory PaymentFormState.initial() => PaymentFormState(