update due date and range date

2026-05-29 18:24:14 +07:00
parent d26f5c5354
commit dc13bb5f93
23 changed files with 640 additions and 84 deletions
@@ -0,0 +1,158 @@
+package validator
+
+import (
+	"testing"
+
+	"apskel-pos-be/internal/constants"
+	"apskel-pos-be/internal/contract"
+
+	"github.com/google/uuid"
+	"github.com/stretchr/testify/require"
+)
+
+func TestExpenseValidatorCreateRequiresItemName(t *testing.T) {
+	v := NewExpenseValidator()
+
+	req := &contract.CreateExpenseRequest{
+		Receiver:        "Cashier",
+		TransactionDate: "2026-05-29",
+		CodeNumber:      "EXP-001",
+		OutletID:        uuid.NewString(),
+		Total:           10000,
+		Items: []contract.CreateExpenseItemRequest{
+			{
+				ChartOfAccountID: uuid.NewString(),
+				Amount:           10000,
+			},
+		},
+	}
+
+	err, code := v.ValidateCreateExpenseRequest(req)
+
+	require.Error(t, err)
+	require.Equal(t, constants.MissingFieldErrorCode, code)
+	require.Contains(t, err.Error(), "item 0: item is required")
+}
+
+func TestExpenseValidatorCreateDoesNotRequireHeaderExpenseName(t *testing.T) {
+	v := NewExpenseValidator()
+
+	req := &contract.CreateExpenseRequest{
+		Receiver:        "Cashier",
+		TransactionDate: "2026-05-29",
+		CodeNumber:      "EXP-001",
+		OutletID:        uuid.NewString(),
+		Total:           10000,
+		Items: []contract.CreateExpenseItemRequest{
+			{
+				ChartOfAccountID: uuid.NewString(),
+				Item:             "Cleaning supplies",
+				Amount:           10000,
+			},
+		},
+	}
+
+	err, code := v.ValidateCreateExpenseRequest(req)
+
+	require.NoError(t, err)
+	require.Empty(t, code)
+}
+
+func TestExpenseValidatorCreateAllowsValidOptionalStatus(t *testing.T) {
+	v := NewExpenseValidator()
+	status := "approved"
+
+	req := &contract.CreateExpenseRequest{
+		Receiver:        "Cashier",
+		TransactionDate: "2026-05-29",
+		CodeNumber:      "EXP-001",
+		OutletID:        uuid.NewString(),
+		Status:          &status,
+		Total:           10000,
+		Items: []contract.CreateExpenseItemRequest{
+			{
+				ChartOfAccountID: uuid.NewString(),
+				Item:             "Cleaning supplies",
+				Amount:           10000,
+			},
+		},
+	}
+
+	err, code := v.ValidateCreateExpenseRequest(req)
+
+	require.NoError(t, err)
+	require.Empty(t, code)
+}
+
+func TestExpenseValidatorCreateRejectsInvalidStatus(t *testing.T) {
+	v := NewExpenseValidator()
+	status := "cancelled"
+
+	req := &contract.CreateExpenseRequest{
+		Receiver:        "Cashier",
+		TransactionDate: "2026-05-29",
+		CodeNumber:      "EXP-001",
+		OutletID:        uuid.NewString(),
+		Status:          &status,
+		Total:           10000,
+		Items: []contract.CreateExpenseItemRequest{
+			{
+				ChartOfAccountID: uuid.NewString(),
+				Item:             "Cleaning supplies",
+				Amount:           10000,
+			},
+		},
+	}
+
+	err, code := v.ValidateCreateExpenseRequest(req)
+
+	require.Error(t, err)
+	require.Equal(t, constants.MalformedFieldErrorCode, code)
+	require.Contains(t, err.Error(), "status must be one of: draft, sent, approved, cancel")
+}
+
+func TestExpenseValidatorUpdateRejectsEmptyItemNameWhenProvided(t *testing.T) {
+	v := NewExpenseValidator()
+	empty := " "
+
+	req := &contract.UpdateExpenseRequest{
+		Items: []contract.UpdateExpenseItemRequest{
+			{Item: &empty},
+		},
+	}
+
+	err, code := v.ValidateUpdateExpenseRequest(req)
+
+	require.Error(t, err)
+	require.Equal(t, constants.MalformedFieldErrorCode, code)
+	require.Contains(t, err.Error(), "item 0: item cannot be empty")
+}
+
+func TestExpenseValidatorUpdateRejectsInvalidStatus(t *testing.T) {
+	v := NewExpenseValidator()
+	status := "cancelled"
+
+	req := &contract.UpdateExpenseRequest{Status: &status}
+
+	err, code := v.ValidateUpdateExpenseRequest(req)
+
+	require.Error(t, err)
+	require.Equal(t, constants.MalformedFieldErrorCode, code)
+	require.Contains(t, err.Error(), "status must be one of: draft, sent, approved, cancel")
+}
+
+func TestExpenseValidatorListRejectsInvalidStatus(t *testing.T) {
+	v := NewExpenseValidator()
+
+	req := &contract.ListExpenseRequest{
+		Page:   1,
+		Limit:  10,
+		Status: "cancelled",
+	}
+
+	err, code := v.ValidateListExpenseRequest(req)
+
+	require.Error(t, err)
+	require.Equal(t, constants.MalformedFieldErrorCode, code)
+	require.Contains(t, err.Error(), "status must be one of: draft, sent, approved, cancel")
+}
@@ -47,18 +47,19 @@ func (v *PurchaseOrderValidatorImpl) ValidateCreatePurchaseOrderRequest(req *con
 		return errors.New("transaction_date must be in YYYY-MM-DD format"), constants.MalformedFieldErrorCode
 	}

-	// Validate due date
-	if strings.TrimSpace(req.DueDate) == "" {
-		return errors.New("due_date is required"), constants.MissingFieldErrorCode
-	}
-	dueDate, err := time.Parse("2006-01-02", req.DueDate)
-	if err != nil {
-		return errors.New("due_date must be in YYYY-MM-DD format"), constants.MalformedFieldErrorCode
-	}
+	if req.DueDate != nil {
+		if strings.TrimSpace(*req.DueDate) == "" {
+			return errors.New("due_date cannot be empty"), constants.MalformedFieldErrorCode
+		}

-	// Check if due date is after transaction date
-	if dueDate.Before(transactionDate) {
-		return errors.New("due_date must be after transaction_date"), constants.MalformedFieldErrorCode
+		dueDate, err := time.Parse("2006-01-02", *req.DueDate)
+		if err != nil {
+			return errors.New("due_date must be in YYYY-MM-DD format"), constants.MalformedFieldErrorCode
+		}
+
+		if dueDate.Before(transactionDate) {
+			return errors.New("due_date must be after transaction_date"), constants.MalformedFieldErrorCode
+		}
 	}

 	if req.Reference != nil && len(*req.Reference) > 100 {
@@ -100,22 +101,27 @@ func (v *PurchaseOrderValidatorImpl) ValidateUpdatePurchaseOrderRequest(req *con
 		}
 	}

-	// Validate dates if both are provided
-	if req.TransactionDate != nil && req.DueDate != nil {
-		if *req.TransactionDate != "" && *req.DueDate != "" {
-			transactionDate, err := time.Parse("2006-01-02", *req.TransactionDate)
-			if err != nil {
-				return errors.New("transaction_date must be in YYYY-MM-DD format"), constants.MalformedFieldErrorCode
-			}
-			
-			dueDate, err := time.Parse("2006-01-02", *req.DueDate)
-			if err != nil {
-				return errors.New("due_date must be in YYYY-MM-DD format"), constants.MalformedFieldErrorCode
-			}
-			
-			if dueDate.Before(transactionDate) {
-				return errors.New("due_date must be after transaction_date"), constants.MalformedFieldErrorCode
-			}
+	var transactionDate *time.Time
+	if req.TransactionDate != nil && *req.TransactionDate != "" {
+		parsedDate, err := time.Parse("2006-01-02", *req.TransactionDate)
+		if err != nil {
+			return errors.New("transaction_date must be in YYYY-MM-DD format"), constants.MalformedFieldErrorCode
+		}
+		transactionDate = &parsedDate
+	}
+
+	if req.DueDate != nil {
+		if strings.TrimSpace(*req.DueDate) == "" {
+			return errors.New("due_date cannot be empty"), constants.MalformedFieldErrorCode
+		}
+
+		dueDate, err := time.Parse("2006-01-02", *req.DueDate)
+		if err != nil {
+			return errors.New("due_date must be in YYYY-MM-DD format"), constants.MalformedFieldErrorCode
+		}
+
+		if transactionDate != nil && dueDate.Before(*transactionDate) {
+			return errors.New("due_date must be after transaction_date"), constants.MalformedFieldErrorCode
 		}
 	}

@@ -0,0 +1,62 @@
+package validator
+
+import (
+	"testing"
+
+	"apskel-pos-be/internal/constants"
+	"apskel-pos-be/internal/contract"
+
+	"github.com/google/uuid"
+	"github.com/stretchr/testify/require"
+)
+
+func validCreatePurchaseOrderRequest() *contract.CreatePurchaseOrderRequest {
+	return &contract.CreatePurchaseOrderRequest{
+		VendorID:        uuid.New(),
+		PONumber:        "PO-001",
+		TransactionDate: "2026-05-29",
+		Items: []contract.CreatePurchaseOrderItemRequest{
+			{
+				IngredientID: uuid.New(),
+				Quantity:     1,
+				UnitID:       uuid.New(),
+				Amount:       1000,
+			},
+		},
+	}
+}
+
+func TestPurchaseOrderValidatorCreateAllowsMissingDueDate(t *testing.T) {
+	validator := NewPurchaseOrderValidator()
+
+	err, code := validator.ValidateCreatePurchaseOrderRequest(validCreatePurchaseOrderRequest())
+
+	require.NoError(t, err)
+	require.Empty(t, code)
+}
+
+func TestPurchaseOrderValidatorCreateRejectsInvalidDueDate(t *testing.T) {
+	validator := NewPurchaseOrderValidator()
+	req := validCreatePurchaseOrderRequest()
+	dueDate := "29-05-2026"
+	req.DueDate = &dueDate
+
+	err, code := validator.ValidateCreatePurchaseOrderRequest(req)
+
+	require.Error(t, err)
+	require.Equal(t, constants.MalformedFieldErrorCode, code)
+	require.Contains(t, err.Error(), "due_date must be in YYYY-MM-DD format")
+}
+
+func TestPurchaseOrderValidatorCreateRejectsDueDateBeforeTransactionDate(t *testing.T) {
+	validator := NewPurchaseOrderValidator()
+	req := validCreatePurchaseOrderRequest()
+	dueDate := "2026-05-28"
+	req.DueDate = &dueDate
+
+	err, code := validator.ValidateCreatePurchaseOrderRequest(req)
+
+	require.Error(t, err)
+	require.Equal(t, constants.MalformedFieldErrorCode, code)
+	require.Contains(t, err.Error(), "due_date must be after transaction_date")
+}